🐛 fix: make internal threads daemon to prevent shutdown hang #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When MPV is killed externally, non-daemon threads block on I/O operations and Python's interpreter shutdown waits for them indefinitely. Setting daemon=True allows Python to exit cleanly without waiting for these threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WindowsSocket,UnixSocket, andEventHandlerthreads daemon threadsProblem
When MPV is killed externally (e.g., Cmd+Q on macOS), the non-daemon threads block on I/O operations (
socket.recv(),queue.get()) and Python's interpreter shutdown waits for them indefinitely. This causes applications using this library to hang for minutes until MPV fully exits.Solution
Setting
self.daemon = Trueon all internal threads allows Python to exit cleanly without waiting for these threads to finish.