Convert arguments of Tod::Shift #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_day convert arguments
…_day Convert arguments to time of day
Owner
|
This is a reasonable change, but it could be done without the ternary test to see if it is already a TimeOfDay. The TimeOfDay function already does that: see https://github.com/jackc/tod/blob/master/lib/tod/conversions.rb#L3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tod::Shiftassumes that its arguments have typeTod::TimeOfDaybut it does not really check it. So I guess it's a good idea to either raise an error if arguments have different type, or to try to convert them to correct type.I chose to convert arguments so one could pass a
StringorTimetoTod::Shift