Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 31, 2026

Responded to maintainer request to document the breaking change introduced in the PR.

Changes:

  • Added comprehensive summary explaining the removal of regex: true/false flag from required_text and forbidden_text patterns
  • Documented the new simplified syntax where string form ("text") implies literal substring matching and object form ({pattern: "..."}) implies regex matching
  • Provided before/after examples and migration guidance

Example:

# Before (old syntax with explicit regex flag)
required_text:
  - { pattern: "example", regex: false }
  - { pattern: "v\\d+\\.\\d+", regex: true }

# After (new syntax - form determines behavior)
required_text:
  - "example"  # string form = literal match
  - { pattern: "v\\d+\\.\\d+" }  # object form = regex match

The breaking change simplifies the API by removing redundant configuration - the syntax form itself now determines matching behavior.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Improve documentation schema system and simplify syntax Add breaking change summary for regex flag removal Jan 31, 2026
Copilot AI requested a review from jackchuka January 31, 2026 05:46
@jackchuka jackchuka marked this pull request as ready for review January 31, 2026 05:48
@jackchuka jackchuka merged commit cfd36c4 into feat/rule/regex-handling Jan 31, 2026
2 checks passed
@jackchuka jackchuka deleted the copilot/sub-pr-34 branch January 31, 2026 05:48
jackchuka added a commit that referenced this pull request Jan 31, 2026
* feat(rule): breaking change - remove regex flag

* test: update tests

* Initial plan (#35)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants