fixed seg fault while recovering wallet by making encryption optional…#13
Open
jeredkenna wants to merge 1 commit intojackjack-jj:masterfrom
Open
fixed seg fault while recovering wallet by making encryption optional…#13jeredkenna wants to merge 1 commit intojackjack-jj:masterfrom
jeredkenna wants to merge 1 commit intojackjack-jj:masterfrom
Conversation
… (leave password blank)
|
Hi, when it gives a segment fault does that mean that the passphrase is incorrect if a passphrase is provided? Thanks |
Owner
|
It's actually a choice to enforce encryption of recovered wallets, I don't want to be responsible of leaked keys |
c2eb216 to
8eef364
Compare
|
I ran into this issue when I was using an older version of pywallet. I did not have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting a seg fault trying to recover a wallet and save it without a password.
Really simple change but if you want to pull this and branch it then some people might find the version useful.