Add RegEx.Replace test and new test case with more variation#1
Open
srutzky wants to merge 2 commits intojadarnel27:masterfrom
Open
Add RegEx.Replace test and new test case with more variation#1srutzky wants to merge 2 commits intojadarnel27:masterfrom
srutzky wants to merge 2 commits intojadarnel27:masterfrom
Conversation
Added ExtractNumbersRegEx_Replace() method since Regex.Replace() does not require a collection or a loop, so this _might_ be more efficient than using Regex.Split().
1) Added test wrapper method to reference new Regex.Replace() test method.
2) Added test cases (both 40 and 4000 character versions), derived from the following T-SQL:
```sql
DECLARE @testD NVARCHAR(4000) = REPLICATE(N'a', 400) + REPLICATE(N'1', 400) + REPLICATE(N'b', 400) + REPLICATE(N'2', 300) + REPLICATE(N'c', 400) + REPLICATE(N'3', 300) + REPLICATE(N'd', 400) + REPLICATE(N'4', 300) + REPLICATE(N'e', 400) + REPLICATE(N'5', 300) + REPLICATE(N'f', 400);
SELECT @testD;
```
and:
```sql
DECLARE @teste NVARCHAR(40) = REPLICATE(N'a', 4) + REPLICATE(N'1', 4) + REPLICATE(N'b', 4) + REPLICATE(N'2', 3) + REPLICATE(N'c', 4) + REPLICATE(N'3', 3) + REPLICATE(N'd', 4) + REPLICATE(N'4', 3) + REPLICATE(N'e', 4) + REPLICATE(N'5', 3) + REPLICATE(N'f', 4);
SELECT @teste;
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ExtractNumbersRegEx_Replace() method since Regex.Replace() does not require a collection or a loop, so this might be more efficient than using Regex.Split().
Added test wrapper method to reference new ExtractNumbersRegEx_Replace() test method.
Added test cases (both 40 and 4000 character versions), derived from the following T-SQL:
and:
NOTE: Unfortunately, I have not had, nor will have, time to test these changes. But everything looks correct 😸 .
Take care,
Solomon...
https://SqlQuantumLift.com/
https://SqlQuantumLeap.com/
https://SQLsharp.com/