Update relationship_converter.py#1
Open
wendellwwood wants to merge 2 commits intojamasoftware-ps:masterfrom
Open
Update relationship_converter.py#1wendellwwood wants to merge 2 commits intojamasoftware-ps:masterfrom
wendellwwood wants to merge 2 commits intojamasoftware-ps:masterfrom
Conversation
Updated function evaluate_relationships to properly handle error response codes. We should allow error 404's to continue to execute as these originate because the calling method 'get_items_of_type' returns all items of that type even if they have been soft deleted (active = F). All other error codes above 400 should be considered to either stop execution or allow it. For now they stop execution.
Update relationship_converter.py
Author
|
If this is change is undesired, I think the webservice call should be updated to not include inactive items. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated function evaluate_relationships to properly handle error response codes. We should allow error 404's to continue to execute as these originate because the calling method 'get_items_of_type' returns all items of that type even if they have been soft deleted (active = F). All other error codes above 400 should be considered to either stop execution or allow it. For now they stop execution.