Conversation
- Add platform abstraction layer (src/platform/) for process management - Unix: uses nix crate for signals and process control - Windows: uses windows-sys for CreateProcessW, TerminateProcess, file locking - Use CreateProcessW with bInheritHandles=FALSE for proper daemon detachment - Wrap shell commands in parentheses for correct output redirection - Update Cargo.toml with platform-specific dependencies - Add cross-platform test helpers in tests/common.rs - Update all integration tests with Windows-compatible commands - Add Windows to GitHub Actions CI matrix - Fix path handling in watch.rs to use std::path APIs All 175 tests pass on Windows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change doc comment to regular comment since it's a section header not documenting the following function. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for cargo's --target flag (cross-compilation target triple) and --all-targets flag (build all target types). Also adds cross-platform clippy and check commands to pls.toml with platform-specific targets. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 78.87% 79.13% +0.26%
==========================================
Files 36 38 +2
Lines 6252 6359 +107
Branches 6252 6359 +107
==========================================
+ Hits 4931 5032 +101
- Misses 975 977 +2
- Partials 346 350 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
james-w
force-pushed
the
feat/windows-support
branch
from
1494dfb to
e226ebe
Compare
On Windows CI, temp directories may use 8.3 short names (e.g., RUNNER~1) which differ from the full paths returned by canonicalize(). Fix by canonicalizing both the expected path and the actual path from the file or command output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
james-w
force-pushed
the
feat/windows-support
branch
from
e226ebe to
7750bf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/platform/) for process managementCreateProcessWwithbInheritHandles=FALSEfor proper daemon detachmenttests/common.rswatch.rsto usestd::pathAPIsTest plan
🤖 Generated with Claude Code