Brightness controls, and use uniform icon styles#2
Open
nicdumz wants to merge 3 commits intojamesridgway:mainfrom
Open
Brightness controls, and use uniform icon styles#2nicdumz wants to merge 3 commits intojamesridgway:mainfrom
nicdumz wants to merge 3 commits intojamesridgway:mainfrom
Conversation
nicdumz
force-pushed
the
main
branch
2 times, most recently
from
2b1e080 to
b80339c
Compare
This adds two Controls, `brightness.Increase` and `brightness.Decrease`, which can increase / decrease brightness respectively. Icons are taken from https://fonts.google.com/icons (SVGs, reexported as plain white-on-transparent 512x512 PNG outlines). Those icons are free, available under an Apache 2.0 license.
Use the 'lightbulb' material icon, outlined for off, and filled for on. Icons are from https://fonts.google.com/icons (free under Apache 2.0), but have been re-exported as white-on-transparent 512x512 pngs.
Contributor
Author
|
Rebased :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey James,
I wonder what you'd think of this PR. The first commit adds brightness controls, something that I generally use on my KeyLight.
As I was shopping around for icons to use for that commit, I found https://fonts.google.com/icons available under Apache 2.0, and wondered if we wanted to essentially just use icons from this set to have some kind of uniform style. (Reasoning: we would have tons of various icons available from that set, available in a consistent style).
I noticed that you had some blue in your on/off icons and in a sense I'm removing that part with my suggestion. If you care about color, I wonder if we'd want to add a color setting, and style on the fly (replacing white strokes by whatever color the user sets, e.g.
color: 2272F0), perhaps as follow-up patch.I don't care strongly about the style of icons, so would be happy to drop the second commit if you'd rather keep what you have at the moment, please let me know. (Last, as a disclaimer, I do work for Google at the moment but I'm not an UX person / I have no particular affiliation with fonts.google.com ; I just happen to find this convenient to use.)
Cheers!