Improved normal estimation and other minor changes #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cuirq3
commented
Nov 21, 2025
cuirq3
commented
- Implement a more robust orientation correction function as VCGlib does
- Implement jet fitting by solving the least square problem
- Adjust code and introduce parallelism to weighted_smooth and estimate_normal
- Remove redundant normal estimation when the input point cloud uses Euclidean distance
cakarsubasi
reviewed
Nov 21, 2025
| else { | ||
| } | ||
| else { | ||
| #pragma omp parallel for schedule(static) |
Contributor
There was a problem hiding this comment.
You can pull GEL/Util/ParallelAdapters.h and use
Parallel::map(ImmediatePool(), vertices, normals, [&]{ /* this entire loop */ return normal; });OpenMP on MacOS requires users to install Homebrew, and then install libomp or LLVM.
Contributor
Author
There was a problem hiding this comment.
Thanks! I will remove them for now :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.