Allow "appname" and "cmdline" parameters to Create() to be NULL #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date: Wed, 27 Dec 2006 03:55:22 -0800
To: bug-libwin32@rt.cpan.org
From: Greg Ercolano <erco@seriss.com>
OK, after reading perlguts and perlxs (woof) I think I get it.
The right approach might be to allow 'undef' on the perl side
to be used where NULL would be needed on the C side to pass to
CreateProcess().
So it seems the simple solution might be to make this simple two line
change to Process.xs:
```
--- Process/Process.xs 2005-09-17 12:36:38.000000000 -0700
+++ Process/Process.xs.erco 2006-12-27 03:19:29.000000000 -0800
@@ -283,6 +283,8 @@
DWORD flags
char *curdir
CODE:
+ appname = SvOK(ST(1)) ? appname : 0;
+ cmdline = SvOK(ST(2)) ? cmdline : 0;
RETVAL = Create(cP, appname, cmdline, inherit, flags, curdir);
OUTPUT:
cP
```
..which then makes this work correctly:
Process::Create($pobj, undef, "netstat -an", 1, NORMAL_PRIORITY_CLASS, ".");
The docs should cover this, so I've included some recommended text
Slightly different implementation of previous. Let perl give us the SV, then decide whether to call SvPV on it based on whether it is defined.
|
@jandubois Can we get this PR merged and cut a new version? We're looking at an IPC::Run issue cpan-authors/IPC-Run#143 (comment) and I think that one can have a decent fix if we support NULL for appname in Win32::Process::Create() |
Owner
|
@stphnlyd I've just uploaded Win32-Process-0.17 to CPAN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Win32 CreateProcess call allows the application name or cmdline arguments to be NULL. Allowing application name to be NULL is the only way to ask Win32 to search the PATH for the executable named in the commandline argument. This is a very useful behavior and would avoid effort in various modules like Proc::Background to have to resolve the executable name by manually searching the PATH.