Added Arduino compliant out of Range handling for the at() function#6
Open
AlexanderTonn wants to merge 1 commit intojanelia-arduino:masterfrom
Open
Added Arduino compliant out of Range handling for the at() function#6AlexanderTonn wants to merge 1 commit intojanelia-arduino:masterfrom
AlexanderTonn wants to merge 1 commit intojanelia-arduino:masterfrom
Conversation
AlexanderTonn
commented
Jan 6, 2024
| { | ||
| Serial.println(" Array Index out of Range! Last valid Index will be returned."); | ||
|
|
||
| auto outOfRangeIndex = arraySize-1; |
Author
There was a problem hiding this comment.
I would remove the local (not good named) variable and inserting the subtraction directly in the bracket operator
- auto outOfRangeIndex = arraySize-1;
- return values_[outOfRangeIndex];
+ return values_[arraySize-1];
AlexanderTonn
commented
Jan 6, 2024
| { | ||
| Serial.println(" Array Index out of Range! Last valid Index will be returned."); | ||
|
|
||
| auto outOfRangeIndex = arraySize-1; |
Author
There was a problem hiding this comment.
I would remove the local (not good named) variable and inserting the subtraction directly in the bracket operator
- auto outOfRangeIndex = arraySize-1;
- return values_[outOfRangeIndex];
+ return values_[arraySize-1];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beforehand, I have to say that I appreciate it that you've created this library! 👍
The big advantage of at() in the std::array lib is the detection of out of ranges indices. The function is throwing an exception if the inserted index is out of range of the array.