feat: Add list passwords for MacOS Keychain#723
Open
dacamposol wants to merge 2 commits intojaraco:mainfrom
Open
feat: Add list passwords for MacOS Keychain#723dacamposol wants to merge 2 commits intojaraco:mainfrom
dacamposol wants to merge 2 commits intojaraco:mainfrom
Conversation
Author
Collaborator
|
I don't use macOS, and don't have experience with its API, so I leave the review to @jaraco. One thing I would ask, though, is to not mix functional changes and style changes (like replacing quotes) in the same commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This pull request introduces a new feature to the macOS backend of the keyring library, enabling users to list all generic passwords stored in the keychain.
Key Changes
New Method Added
list_passwordsmethod is added tomacOS.Keyring, allowing retrieval of all generic passwords.api.list_generic_passwords()function.API Enhancements
Implements
list_generic_passwords()inmacOS/api.py, which:CFStringRef,CFDataRef) to Python strings for easier handling of keychain data.Testing
A new test
test_list_generic_passwordsintests/backends/test_macOS.pyverifies:Impact
TLDR; This PR enhances the macOS backend by adding password listing capability, improves type conversions, and provides robust tests for the new functionality.