feat: support outline* style props
#374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
sorry about the mess here, can you rebase this? i tried to do it, but i can't push to your branch, or i'm not clear how to resolve it myself. |
…native-classnames into @simek/feat-support-outline-styles # Conflicts: # src/UtilityParser.ts
Simek
force-pushed
the
@simek/feat-support-outline-styles
branch
from
20890ea to
1507624
Compare
Contributor
Author
|
No worries, I think it should be good now! |
Owner
|
@Simek it's still showing conflicts in the github ui... 🤔 |
Contributor
Author
|
Hmm, that's interesting, I don't see any on my side 🤔 
|
Owner
|
Contributor
Author
|
Indeed there is something off which has happen here after shipping other PRs, since main branch ref become Re-created the PR with the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Spotted some warnings in console related to
outline*style props which has been added in React Native 0.77 for better compatibility with CSS.How
Add support for
outlineStyle,outlineOffset,outlineWidthandoutlineColorstyle props, add test spec covering various class values related to outline.All possible classes, besides
outlinehas been supported via dedicated resolvers. The stand-aloneoutlineclass has been supported via simple mapping to avoid complicating parsing. Please let me know if this is a correct approach!According to Talwind docs, I have also added new keys (
outlineOffsetand `outlineWidth) for the theme customization.Refs: