Deleted missing references & added DirectX SDK files#5
Open
protocultor wants to merge 2 commits intojarikomppa:masterfrom
Open
Deleted missing references & added DirectX SDK files#5protocultor wants to merge 2 commits intojarikomppa:masterfrom
protocultor wants to merge 2 commits intojarikomppa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Studio 2017 will complain about a missing "ddoutput.h" when trying to compile. Also, there's a declaration of a nonexistent "d3d9InterfaceQuery". With both gone, VS 2017 works fine.
Also, all three DirectX 8.1 header files are included and referenced directly in the solution; it's better to include 324 KB here than to ask for 170 MB that will be unused for the most part. The best aspect is that no one will need to change their "IncludePath"; both the generator and the wrapper are ready to compile.