This repository was archived by the owner on Dec 3, 2020. It is now read-only.
Spec 1157 api client setuptools #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement proper setuptools setup script and set required dependencies in script; drop requirements.txt - Fix up imports in trident_client modules to do proper relative imports within the package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping to slightly modernize and improve the python client API code incrementally here just to fix up that some of our scripts don't seem to run at all in the current incarnation. See commit logs for details. Tested in a Python 3 virtualenv with this setup and was able to properly update the netblocks in a customer after streamlining this module. Prior it seemed to be a dance to get in the proper directory to do some imports and even then I'm not convinced it would have been able to work. This should hopefully better fit current patterns in e.g. https://python-packaging.readthedocs.io/en/latest/.
One thing I'm hoping you can verify @josh-williams is that we're OK dropping the requirements.txt since those are now present in setup.py (
install_requires).@spdietz if this is clear I'd like to do another test and then update the user-facing doc in https://jasklabs.atlassian.net/wiki/spaces/CS1/pages/695730197/Importing+Network+Blocks+using+the+JASK+REST+API.