Conversation
| testthat (>= 3.0.3), | ||
| vdiffr (>= 1.0.2) | ||
| vdiffr (>= 1.0.2), | ||
| jaspBase |
There was a problem hiding this comment.
Is this necessary? Originally, the idea was that jaspTools could do things, like installing jaspBase, for a developer. But this kinda looks like it becomes a cycle. Or is this intended as a workaround until we get rid of jaspTools altogether?
There was a problem hiding this comment.
even though we already had things like jaspBase:::.vdf before, this change will make it impossible to install jaspTools without first installing jaspBase.
There was a problem hiding this comment.
No it's not necessary, but since we are using jaspBase anyway I figured it might as well be specified as a dependency - hence I asked before whether it's deliberate that it's excluded.
So I guess I am saying I can remove it - as you say jaspTools sets up jaspBase anyway so it's not a gib deal.
There was a problem hiding this comment.
oops sorry I missed that in your message.
I'll update the R version for the unit tests, hashtab was introduced later. |
|
@Kucharssim can you rebase/ retrigger the tests? If I rerun them they still use the old R version. |
Goes in tandem with: jasp-stats/jaspBase#136
Instead of relying on rbridge finding the
readDatasetToEndNativein jaspTools, we just rely on the new data set functionality injaspBase. I added jaspBase as a dependency explicitly now (even though we used to call it from jaspTools before as well) - or is there a reason for not doing it?