remove reference to development bundle #8
Conversation
Boefjim
left a comment
Boefjim
left a comment
There was a problem hiding this comment.
Would love to see this merged after these changes!
|
|
||
| composer config repositories.ics_bundle '{"type": "vcs", "url": "git@github.com:tacman/IcsBundle.git"}' | ||
| composer req jsvrcek/ics-bundle:dev-tac | ||
| composer req jsvrcek/ics-bundle |
There was a problem hiding this comment.
Maybe it's a good idea to mark this as a command?
| composer req jsvrcek/ics-bundle | |
| `composer req jsvrcek/ics-bundle` |
| namespace App\Services; | ||
| private Formatter $formatter; | ||
| private CalendarExport $calendarExport; | ||
|
|
||
| class HelloController | ||
| class MyService | ||
| { | ||
|
|
||
| public function __construct(Formatter $formatter, CalendarExport $calendarExport) { | ||
|
|
||
| $this->formatter = $formatter; | ||
| $this->calendarExport = $calendarExport; | ||
| } |
There was a problem hiding this comment.
Since you are using code blocks, the indentation is no longer necessary
|
|
||
|
|
||
| // or inject them into the controller | ||
| ```php |
There was a problem hiding this comment.
This is missing a closing line, also then no longer needs indentation
|
@Boefjim thanks - I've merged and created a new tag, 1.1. |
The changes I've made were not actually part of the PR yet since I couldn't edit it directly, so had to add it as suggested changes instead, but I made another PR for it from my own fork if you still want to get the changes merged: #10 It's also not really necessary to add a new tag since it's just documentation changes :P |
3 participants
Also, the php is now properly displayed.