ДЗ 1, Симиютин Борис, подгруппа 2#11
Open
simiyutin wants to merge 2 commits intojava-course-au:01-string-setfrom
Open
ДЗ 1, Симиютин Борис, подгруппа 2#11simiyutin wants to merge 2 commits intojava-course-au:01-string-setfrom
simiyutin wants to merge 2 commits intojava-course-au:01-string-setfrom
Conversation
Author
sproshev
approved these changes
Feb 24, 2017
| final int size = 7; | ||
| assertTrue(stringSet.size() == size); | ||
|
|
||
| assertTrue(stringSet.howManyStartsWithPrefix("i") == 2); |
There was a problem hiding this comment.
см assertEquals, в случае несовпадения он распечатает оба значения
|
|
||
| public class StringSetImpl implements StringSet { | ||
|
|
||
| private int size; |
| private Node[] children; | ||
| private char value; | ||
| private int numberOfChildren; | ||
| private int howManyStartsWithPrefix; |
There was a problem hiding this comment.
numberOfChildren и howManyStartsWithPrefix как-нибудь связаны?
Author
There was a problem hiding this comment.
Действительно, они полностью друг друга дублируют, и от одного поля можно избавиться
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.