Skip to content

don't fail when the templater can't find table markers for an array i…#13

Open
elliotwesoff wants to merge 1 commit intojawspeak:masterfrom
elliotwesoff:non_strict_markers
Open

don't fail when the templater can't find table markers for an array i…#13
elliotwesoff wants to merge 1 commit intojawspeak:masterfrom
elliotwesoff:non_strict_markers

Conversation

@elliotwesoff
Copy link

don't fail when the templater can't find table markers for an array in the data hash.

basically so that you can use a variety of templates with the same set of data, but won't crash if you only use a small portion of the data.

@jawspeak
Copy link
Owner

thanks - i think the build is failing @elliotwesoff - maybe make this a config option / and fix the tests?

appreciate the pull request!

@elliotwesoff
Copy link
Author

Hey thanks for replying! It looks like you wrote a test to make it
intentionally fail, so I figured you wanted it to do that, so I didn't
change the test. But sure, I'll see what I can do!

On Mon, Nov 23, 2015 at 9:40 AM, Jonathan Andrew Wolter <
notifications@github.com> wrote:

thanks - i think the build is failing @elliotwesoff
https://github.com/elliotwesoff - maybe make this a config option / and
fix the tests?

appreciate the pull request!


Reply to this email directly or view it on GitHub
#13 (comment)
.

Elliot W.
Tel: 626-533-1436, ext. 108
850 S Myrtle Ave
Monrovia, CA. 91016
www.techrockstars.com

@jawspeak
Copy link
Owner

happy to merge if the tests are passing!

@tamird tamird force-pushed the master branch 2 times, most recently from 91769bb to 938a755 Compare May 3, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants