-
Notifications
You must be signed in to change notification settings - Fork 1
History/database helper #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Once you merge the previous PR, rebase this with the master and assign it back to me. |
65c4e13 to
c2d971f
Compare
This class contains sql code and column names to be used in the history plugin's code. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
The DatabaseManager class contains code to interact with the history plugin's database. Functions such as database creation, table creation, inserts and searches are handled in this class. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
This enables logging of chats to an sqlite database. The plugin intercepts each sent/received message and logs it to the database file in the user's app data folder. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
Add SQL code to be used when retrieving the contacts involved in chats for a particular account. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
Prefix the functions for getting SQL queries with sql_ for easier reference. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
c2d971f to
9896325
Compare
|
Done. Rebased with master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make it a TODO Shall we ?
Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
Whitespace correction. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
This avoids hand coding column names in the C++ code. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
|
I have assigned this back to you. I will read more about the K_GLOBAL_STATIC. |
plugins/history/chathistoryplugin.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space ❗
Fix some of the longer lines to a manageable length. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
|
I am working on a StringBuilder class now. |
Emit error messages when the database is not open. Signed-off-by: Joseph W. Joshua <joejoshw@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗
|
@josh-wambua : If you are still working on a few stuff, you should probably finish them up before assigning it back to me. 😸 |
|
Any updates on this one? |
|
QueryBuilder coming up tomorrow |
This branch is based on the prepare branch, and contains code to interface with the database. This enables full database logging.
To be reviewed after #3