Add cdb.Get and command 'cdbget'; no fs dependency in tests #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the [cdbget][1] program as described by DJB. [1] http://cr.yp.to/cdb/cdbget.html
By provding a very simple io.WriteSeeker-implementation (memFile) the need to write/read real files in the testing code is gone. Instead of having one big test function I splitted it into a bunch of topic-related ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an interface to cdb.Get to port 'cdbget' to Golang. I also tweaked the cdb_test.go a little bit by implementing a []byte-backed io.WriteSeeker to avoid any filesystem related dependencies while running tests.