Handle empty input in String's FromBytesWithInput implementation#306
Closed
oherrala wants to merge 1 commit intojbaublitz:mainfrom
Closed
Handle empty input in String's FromBytesWithInput implementation#306oherrala wants to merge 1 commit intojbaublitz:mainfrom
oherrala wants to merge 1 commit intojbaublitz:mainfrom
Conversation
This fixes "attempt to subtract with overflow" error when the input buffer is empty. In this case buffer.position() + input - 1 is 0 + 0 - 1 leading to integer overflow. In release builds integer overflows are not checked which could lead into out of bounds read of the buffer. While here validate UTF-8 string before allocating memory for it.
Owner
|
@oherrala Are you going to resubmit this? |
Contributor
Author
|
@jbaublitz I was too hasty and misunderstood some of the code. I opened #307 with maybe more understanding of the code on my part. Sorry about the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes "attempt to subtract with overflow" error when the input buffer is empty. In this case
buffer.position() + input - 1is0 + 0 - 1leading to unsigned integer overflow.In release builds integer overflows are not checked which could lead into out of bounds read of the buffer.
While here validate UTF-8 string before allocating memory for it.
Error from included test before fix is applied:
neli/src/lib.rs
Lines 435 to 439 in 7c6a1f9