Conversation
Owner
Author
|
I believe I've found a couple ways this PR can leak file descriptors in error paths. I'll work on handling file descriptor clean up correctly. |
When dropped, NlRouter would not shut down the thread. This resulted in what is effectively a memory leak with threads hanging around and never being cleaned up. This change provides fixes for both the synchronous and asynchronous variants, waiting on both the socket for input and the exit notifier to avoid this problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #308
When dropped, NlRouter would not shut down the thread. This resulted in what is effectively a memory leak with threads hanging around and never being cleaned up.
This change provides fixes for both the synchronous and asynchronous variants, waiting on both the socket for input and the exit notifier to avoid this problem.
I believe I've confirmed both the original problem and resolved it with the PR.