Skip to content

Conversation

@mon
Copy link
Contributor

@mon mon commented Apr 8, 2025

The doc for utime:

If times is not None, it must be a 2-tuple of the form (atime, mtime) where each member is an int or float expressing seconds.

However, providing floats throws:

TypeError: Cannot parse value for field last_access_time of type float to an int

This fixes that and adds a unit test to verify.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.03%. Comparing base (9f3e83e) to head (dc84653).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   99.05%   99.03%   -0.02%     
==========================================
  Files          24       24              
  Lines        5184     5184              
==========================================
- Hits         5135     5134       -1     
- Misses         49       50       +1     
Flag Coverage Δ
arm64 68.22% <100.00%> (ø)
macOS 68.22% <100.00%> (ø)
py3.10 98.99% <100.00%> (ø)
py3.11 98.99% <100.00%> (-0.02%) ⬇️
py3.12 98.99% <100.00%> (ø)
py3.13 98.99% <100.00%> (ø)
py3.8 98.99% <100.00%> (ø)
py3.9 99.03% <100.00%> (ø)
ubuntu 96.83% <100.00%> (ø)
windows 98.95% <100.00%> (-0.02%) ⬇️
x64 99.03% <100.00%> (ø)
x86 98.95% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding the test as well!

@jborean93 jborean93 merged commit c3be43d into jborean93:master Apr 9, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants