Skip to content

Propagate missing session params #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuperBuker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Propagate missing session params #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/smbclient/_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,15 @@ def delete_session(server, port=445, connection_cache=None, timeout=60):


def get_smb_tree(
path, username=None, password=None, port=445, encrypt=None, connection_timeout=60, connection_cache=None
path,
username=None,
password=None,
port=445,
encrypt=None,
connection_timeout=60,
connection_cache=None,
auth_protocol=None,
require_signing=True,
):
"""
Returns an active Tree connection and file path including the tree based on the UNC path passed in and other
Expand All @@ -253,7 +261,7 @@ def get_smb_tree(
client_config = ClientConfig()
username = username or client_config.username
password = password or client_config.password
auth_protocol = client_config.auth_protocol
auth_protocol = auth_protocol or client_config.auth_protocol

# In case we need to nest a call to get_smb_tree, preserve the kwargs here so it's easier to update them in case
# new kwargs are added.
Expand All @@ -264,6 +272,8 @@ def get_smb_tree(
"encrypt": encrypt,
"connection_timeout": connection_timeout,
"connection_cache": connection_cache,
"auth_protocol": auth_protocol,
"require_signing": require_signing,
}

# Normalise and check that the path contains at least 2 components, \\server\share
Expand Down Expand Up @@ -311,6 +321,7 @@ def get_smb_tree(
connection_timeout=connection_timeout,
connection_cache=connection_cache,
auth_protocol=auth_protocol,
require_signing=require_signing,
)

share_path = rf"\\{server}\{path_split[1]}"
Expand Down