Adding a shutdown flag to HttpServer for use in both blocking, non-blocking modes#1
Open
SteveHespelt wants to merge 6 commits intojbuehl:mainfrom
Open
Adding a shutdown flag to HttpServer for use in both blocking, non-blocking modes#1SteveHespelt wants to merge 6 commits intojbuehl:mainfrom
SteveHespelt wants to merge 6 commits intojbuehl:mainfrom
Conversation
added unittests for blocking server
…=True will terminate accept() looping Fair amount of code formatting cleanup.
Cleanup (to some extent) comments, doc strings.
removed pyproject.toml from .gitignore since we're now using it. TODO: get intended version value from Joe Buehl before PR merging. update pyproject.toml with intended value.
…-Files pyproject.toml, setuptools properties.
Owner
|
Thanks for this PR. It looks like something I will probably add to the project, but I don't have time to review it just now. |
Author
|
Hi Joe,
Thanks for considering it. I've added (but not yet pushed) a commit with the pyproject.toml working with recent build, packaging to get a wheel file. Didn't want to push until you have a chance to review, suggest a version (eg. 0.5.1 ?) for it. I've got a local devpi service I'll upload the wheel to for local usage.
-steve
Steven Hespelt
SERC Software Engineer
SERC
M: 201-819-4815
[Stevens logo]<https://www.stevens.edu/>
Inspired by Humanity, Powered by Technology(tm)
Instagram<https://www.instagram.com/followstevens/> | Twitter<https://twitter.com/FollowStevens> | Facebook<https://www.facebook.com/Stevens1870> | YouTube<https://www.youtube.com/EdwinAStevens70>
From: jbuehl ***@***.***>
Sent: Wednesday, March 12, 2025 11:25 AM
To: jbuehl/picohttp ***@***.***>
Cc: Steven Hespelt ***@***.***>; Author ***@***.***>
Subject: Re: [jbuehl/picohttp] Adding a shutdown flag to HttpServer for use in both blocking, non-blocking modes (PR #1)
CAUTION: This email originated from outside of Stevens. Please do not click links or open attachments unless you recognize the sender and know the content is safe.
Thanks for this PR. It looks like something I will probably add to the project, but I don't have time to review it just now.
-
Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ6EXXASCGDLWWMCQTLI4GT2UBGUXAVCNFSM6AAAAABYWMYVZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJYGI3DCOBRGY>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
[jbuehl]jbuehl left a comment (jbuehl/picohttp#1)<#1 (comment)>
Thanks for this PR. It looks like something I will probably add to the project, but I don't have time to review it just now.
-
Reply to this email directly, view it on GitHub<#1 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ6EXXASCGDLWWMCQTLI4GT2UBGUXAVCNFSM6AAAAABYWMYVZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJYGI3DCOBRGY>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Owner
|
I already have a pyproject.toml, however I am ignoring it with git, along with the dist/ and picohttp.egg-info/ directories that are involved in the PyPI distribution. I was unclear whether it belongs in the github repo or not. I think adding the rutifu dependency is a good idea though. I don't have much experience with this, so I don't know what the [tools.*] sections in your PR are for. Here's what I currently have: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Joe,
I have a need for a HttpServer 'component' in various Python scripts, Jupyter notebooks, to handle incoming POSTs of XML and/or JSON, especially in a blocking 1-request only mode. So I did a quick search of existing PyPI packages, came across yours (picohttp), thought it would (with some minimal mods) meet my use cases quite well & without being too extensive for my simple use case. So I forked the project, made the changes, and added a few unittest based test files.
Hopefully you'll see some value in incorporating the changes? No offense if not.
I'm thinking of adding a simple pyproject.toml, to generate a wheel file so the use of rutifu is embedded in the resulting wheel's metadata... (since that's the only non-stdlib dependency). If you think that's useful, I can do so before any action is taken on this PR. I appreciate any suggestions, feedback as well.
Hope this PR finds you doing well. And thank you for creating picohttp. It will be useful.