Skip to content

correct response pattern matching and add nil check #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dillinger wants to merge 3 commits into
base: master
Choose a base branch
from
Open

correct response pattern matching and add nil check #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3456bd6
add nil check in Nosedrum.Storage.Dispatcher
dillinger Feb 8, 2026
0cd5dbe
return :ok instead of {:ok} from Dispatcher.handle_interaction
dillinger Feb 8, 2026
3d0cf0e
fix order of aliases in Nosedrum.Converters
dillinger Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/nosedrum/converters.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ defmodule Nosedrum.Converters do

alias Nostrum.Error.ApiError
alias Nostrum.Snowflake
alias Nostrum.Struct.Guild.{Member, Role}
alias Nostrum.Struct.{Channel, Guild}
alias Nostrum.Struct.Guild.{Member, Role}

@typedoc """
Additional options that were used when searching the cache.
Expand Down
4 changes: 2 additions & 2 deletions lib/nosedrum/storage/dispatcher.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ defmodule Nosedrum.Storage.Dispatcher do
{:error, :unknown_command}

# the response type was not a callback tuple, no need to follow up
res_type when is_atom(res_type) or is_integer(res_type) ->
{:ok}
res_type when is_atom(res_type) or is_integer(res_type) or is_nil(res_type) ->
:ok

{:error, reason} ->
{:error, reason}
Expand Down