Add checkbox for Builder to fail deployment when there are no artifacts.#11
Add checkbox for Builder to fail deployment when there are no artifacts.#11genericpenguin wants to merge 7 commits intojenkinsci:masterfrom
Conversation
|
Hi @seanturner83, Would you be able to have a peek at this when you have a chance? Sorry, I can't add reviewers (I might have sporked the procedure for pull requests in to Jenkins plugins because noob). Sven Schott |
|
LGTM, and CI has completed successfully - I'll test the .hpi later and merge, then I just need to find time to set up the faffy release process on a new laptop! Wonder if we got unblocked by the security team yet? |
|
Just a quick ping to see if this is still on the cards. I would love to see it go through just so I can have the official release on my Jenkins instead of my local build. :) |
|
Sorry, just another ping to see if this will be merged soon. If there's anything I can do to help, please let me know. |
|
Hey @seanturner83 |
|
@genericpenguin the plugin is up for adoption. That usually means that the current maintainers are no longer actively maintaining it. If you're willing to become a maintainer of the plugin, follow the steps in "Adopt a plugin". We'd love to have your help. |
|
@genericpenguin Please provide automated tests to hit your changes. Everything else LGTM |
The ArtifactDeployer Build step does not have an option to fail the build when there are no artifacts, which the Publishing step does have. These changes add the same checkbox to the Build step. I have pretty much copy pasted the code from the ArtifactDeployerPublisher class and updated the jelly file accordingly. The code compiles and I have tested it on a local instance of Jenkins (fails the build when there are no files and the checkbox is active, does not fail when there are no files and the checkbox is inactive).