Remove external dependency on ant-filesystem-tasks#13
Open
astoltz wants to merge 12 commits intojenkinsci:masterfrom
Open
Remove external dependency on ant-filesystem-tasks#13astoltz wants to merge 12 commits intojenkinsci:masterfrom
astoltz wants to merge 12 commits intojenkinsci:masterfrom
Conversation
mawinter69
suggested changes
Nov 8, 2019
src/main/java/org/jenkinsci/plugins/artifactdeployer/service/PermissionsUtils.java
Outdated
Show resolved
Hide resolved
|
@alecharp be sure, that the automatad qality gates are passed. Also it will be fine to provide some automate testcases to cover new lines. |
Member
|
@mPokornyETM sure, but I just merged the current master branch into this pull request to see if it was enough to see it revived. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull in the 2 classes being used from ant-filesystem-tasks in order to remove the external dependency. This adds compatibility with Jenkins 2.190.1 LTS.