Skip to content

Conversation

@timja
Copy link
Member

@timja timja commented Jan 26, 2026

Reverts #1008

Probably won't ship this as its they aren't needed on Windows but worth a test for #999 (comment)

@timja timja mentioned this pull request Jan 26, 2026
6 tasks
@jtnord
Copy link
Member

jtnord commented Jan 26, 2026

@timja
Copy link
Member Author

timja commented Jan 26, 2026

@jtnord you think its worth re-enabling these on Windows?

@timja
Copy link
Member Author

timja commented Jan 26, 2026

@jtnord
Copy link
Member

jtnord commented Jan 26, 2026

40 seconds on Windows instead of 10 seconds on Linux:

That's par for the course on Windows for RealJenkinsRule (and JenkinsRule) (mostly overhead unzipping the war / hpi IIRC)

do you think its worth re-enabling these on Windows?

I see no reason to exclude them on developer machines (or CI)

@timja timja marked this pull request as ready for review January 26, 2026 19:51
@timja timja requested a review from a team as a code owner January 26, 2026 19:51
@timja timja changed the title Test if fips tests are faster on Windows Re-enable fips tests on Windows Jan 26, 2026
@timja timja added the tests label Jan 26, 2026
@timja timja merged commit f0b4a73 into master Jan 26, 2026
20 checks passed
@timja timja deleted the revert-1008-fips-windows branch January 26, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants