New credentials dialog #992

timja · 2025-12-29T15:46:01Z

Adds a "New credentials" link to Credentials page.
Improves UX of selecting a credentials type
Uses dialogs when creating credentials to improve the experience.

credentials.mov

Part of #986

Fixes #939

ATH passed in jenkinsci/acceptance-test-harness#2565

TODO:

Testing done

Single level folder
System credentials
User credentials
ATH
Integration tests in this plugin
Nested folders

nested folder example:

Tested with:

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests that demonstrate the feature works or the issue is fixed

timja · 2026-01-11T12:29:55Z

I've noticed a couple of times in ATH that behaviour isn't running in time and the scope dropdown is empty:

Would be good to fix this

timja · 2026-01-11T13:36:46Z

Example here I think:
https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-2565/5/testReport/plugins/GitPluginTest/latest_linux_jdk21_firefox_split6___custom_name_and_email/

aster200632705|Caused: java.lang.IllegalArgumentException: Failed to instantiate class com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey from {"stapler-class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey","$class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey","scope":"","id":"","description":"","username":"gitplugin","usernameSecret":false,"privateKeySource":{"value":"0","privateKey":"[value redacted]","$redact":"privateKey","stapler-class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey$DirectEntryPrivateKeySource","$class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey$DirectEntryPrivateKeySource"},"passphrase":"[value redacted]","$redact":"passphrase"}
master200632705|	at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:870)
master200632705|	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:633)
master200632705|	at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:628)
master200632705|	at hudson.model.Descriptor.bindJSON(Descriptor.java:662)
master200632705|	at hudson.model.Descriptor.newInstanceImpl(Descriptor.java:620)
master200632705|Caused: java.lang.LinkageError: Failed to instantiate class com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey from {"stapler-class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey","$class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey","scope":"","id":"","description":"","username":"gitplugin","usernameSecret":false,"privateKeySource":{"value":"0","privateKey":"[value redacted]","$redact":"privateKey","stapler-class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey$DirectEntryPrivateKeySource","$class":"com.cloudbees.jenkins.plugins.sshcredentials.impl.BasicSSHUserPrivateKey$DirectEntryPrivateKeySource"},"passphrase":"[value redacted]","$redact":"passphrase"}

timja · 2026-01-13T08:27:26Z

That was resolved, main thing left is ATH to sort.... taking quite awhile...

timja · 2026-01-16T14:31:00Z

Something weird is going on.

Sometimes (in ATH) the Add button for adding an SSH username with password doesn't work.

https://github.com/jenkinsci/acceptance-test-harness/pull/2565/checks?check_run_id=60413734684

https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-2565/9/testReport/plugins/WorkflowPluginTest/latest_linux_jdk25_firefox_split4___hello_world_from_git/

I can reproduce it rarely when I run an ATH test, can't reproduce interactively.
There's no browser console errors.
But if you click the Add button nothing happens.

Something to do with behaviour not registering.

Help appreciated if anyone has time.

timja · 2026-01-25T16:26:38Z

ATH passing 🎉

Just need to review TODOs

timja · 2026-01-25T19:04:20Z

@jtnord would appreciate a review if possible, thanks.

Jenkinsfile

jtnord · 2026-01-26T17:12:04Z

...esources/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/dialog.jelly

+ -->
+<?jelly escape-by-default='true'?>
+<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:f="/lib/form">
+    <st:setHeader name="X-Wizard-Title" value="${%Add Credentials}" />


X-Wizard-Title?

jtnord · 2026-01-26T17:16:21Z

...esources/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/dialog.jelly

+            </j:otherwise>
+        </j:choose>
+
+        <form action="${relativePath}dialog2${query}" method="GET" name="dialog">


is there some subtle security issue here? can I craft a link to this with ${thepath}?relativePath=https://somewhere-else.com/someform to change the form submission to go to a completely different server?

jtnord · 2026-01-26T17:18:04Z

...sources/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/dialog2.jelly

+
+    <l:ajax>
+        <f:form id="credentials-dialog-form"
+                action="${request2.getParameter('relativePath')}/createCredentials" method="POST" name="newCredentials">


relativePath is user supplied and IIRC stapler will pull this out from https://my.jenkins/whatever...?relativePath=http://somewhereelse.com/someotherform

jtnord · 2026-01-26T17:22:22Z

src/main/resources/com/cloudbees/plugins/credentials/common/card.css

+    margin-bottom: 1.5rem;
+}
+
+.jenkins-choice-list {


should this changing /defining styles in the jenkins hierachy? (I have no idea about how this gets mapped)

jtnord · 2026-01-26T17:24:16Z

src/main/resources/lib/credentials/select.jelly

                  checkMethod="${attrs.checkMethod}"/>
-        <!-- TODO  add support for checking permissions against stores in request path -->
-        <j:set var="storeItems" value="${selectHelper.getStoreItems(context, includeUser)}"/>
+        <!-- TODO look into includeUser -->


is this valid? did things work (excepting permissions issues and failing hard) before and not now?

jtnord · 2026-01-26T17:25:48Z

src/main/resources/lib/credentials/select/select.js

+    const backButton = document.createElement("button");
+    backButton.classList.add("jenkins-button");
+    backButton.classList.add("jenkins-dialog__back-button");
+    backButton.innerHTML = `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="48" d="M328 112L184 256l144 144"/></svg>`;
+    title.style.transition = "var(--standard-transition)";
+    title.style.marginLeft = "2.75rem";
+    dialog.appendChild(backButton);


Looks like this needs some aria accessibility attributes?

jtnord · 2026-01-26T17:34:13Z

I get an unneeded scrollbar when attempting to add a credential.

jtnord · 2026-01-26T17:45:43Z

not sure if this is an issue somewhere in Jenkins core or here, but if I click in the dialog (in certain places) it closes it unexpectedly.
It also closed it if I click outside the dialog (possibly more expected - but was a surprise to me when there is a specifix close (X) button.

the purple area seems to dismiss in the following:

As I may be part way through completing something I would not expect this to occur.

jtnord · 2026-01-26T17:47:49Z

credential type options seem to be completely inaccessible (chrome windows) - I can not tab to them, space and arrows control the page in the background of the dialog. I can tab to the X and the next button, but not the individual credential types

jtnord · 2026-01-26T17:56:04Z

NIT: the bottom floating buttons are missing some styling from the normal stick floating button bar on core pages.
there is no bluring of the background behind them.

e.g.

Possibly not possible, but it would be great for the ATH if the bottom button bar was outside of the scroll for the rest of the dialog (similar to the title) so that you did not have to mess with disabling the sticky button with js.

timja and others added 30 commits December 19, 2025 22:53

Use card layout for credentials tables

852e45a

Refine card UI

b633bf9

Adjust colors + padding

27276a3

Update domain items

10b4636

Add Configure button

8d9e091

Add credential count

9302a64

Start migrating home page

2f8f1dd

WIP homepage cards

e30d6ed

Update credentials.css

a06256d

Fixes

08fd291

Refine further

600c93d

Update credentials.css

1a1805b

Add missing check

4a94613

Remove no longer needed brackets

4bcb15b

Fix non editable stores showing actions

b6353cd

Add empty state support

850049f

Remove unneeded brackets around description

2947831

Drop the .

ce2e83f

Switch to adjunct for settings-subpage compat

a5ed6be

Fix text wrap, fix icon shrinking + alignment

a41d5cf

Fix description wrap

3b0cb04

Pull out Stores into own Jelly file

02d734e

Use symbol-business-outline plugin-ionicons-api

0123378

Fix page description spacing

f9b420a

Use dialog for deleting domains

18109b0

Use dialog for deleting credentials

8df7aa8

Update index.jelly

21f5196

Fix ATH

b8944f9

Basic new credentials dialog

4645df8

Working

0ccee24

Tests pass on this baseline

4fe9e4e

Improve Behaviour handling

172b32e

timja mentioned this pull request Jan 17, 2026

Improve error handling in findFormParent jenkinsci/jenkins#26137

Merged

14 tasks

timja added 2 commits January 24, 2026 22:47

Seems to help

7b22a19

Fast build

ce68da0

timja mentioned this pull request Jan 25, 2026

Adapt to New credentials dialog (don't merge) jenkinsci/acceptance-test-harness#2565

Draft

6 tasks

timja added 2 commits January 25, 2026 14:30

Revert changes

e64d7d4

Merge branch 'master' into new-credentials-dialog

4eaf41d

timja marked this pull request as ready for review January 25, 2026 16:25

timja requested a review from a team as a code owner January 25, 2026 16:25

timja marked this pull request as draft January 25, 2026 16:26

Update descriptions

f792862

timja marked this pull request as ready for review January 25, 2026 19:03

timja mentioned this pull request Jan 25, 2026

Minor dropdown / notice tweaks jenkinsci/jenkins#26189

Open

14 tasks

PR created to backport style fixes

4243d55

This comment was marked as resolved.

Sign in to view

Fix nested folder

5748769

jtnord reviewed Jan 26, 2026

View reviewed changes

Jenkinsfile Show resolved Hide resolved

Revert fast build

0f40810

jtnord reviewed Jan 26, 2026

View reviewed changes

New credentials dialog #992

Are you sure you want to change the base?

New credentials dialog #992

Conversation

timja commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Testing done

Submitter checklist

Uh oh!

timja commented Jan 11, 2026

Uh oh!

timja commented Jan 11, 2026

Uh oh!

timja commented Jan 13, 2026

Uh oh!

timja commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timja commented Jan 25, 2026

Uh oh!

timja commented Jan 25, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

jtnord Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jtnord Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jtnord Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jtnord Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jtnord Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jtnord Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

jtnord commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtnord commented Jan 26, 2026

Uh oh!

jtnord commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtnord commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timja commented Dec 29, 2025 •

edited

Loading

timja commented Jan 16, 2026 •

edited

Loading

jtnord commented Jan 26, 2026 •

edited

Loading

jtnord commented Jan 26, 2026 •

edited

Loading