Open
Conversation
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor code cleanup
jglick
reviewed
May 28, 2025
| import org.jvnet.hudson.test.JenkinsRule; | ||
| import org.jvnet.hudson.test.junit.jupiter.WithJenkins; | ||
|
|
||
| class JCasCTest { |
Contributor
Author
There was a problem hiding this comment.
Mhh, I think it was mainly to satisfy my inner Monk. It's the "official" naming, isn't it? Most similar implementations in other plugins are named the same way.
jglick
reviewed
May 28, 2025
Comment on lines
-123
to
+135
| .grant(Jenkins.READ).everywhere().to("alice", "bob") | ||
| .grant(Computer.BUILD).everywhere().to("alice", "bob") | ||
| .grant(Jenkins.READ) | ||
| .everywhere() | ||
| .to("alice", "bob") | ||
| .grant(Computer.BUILD) | ||
| .everywhere() | ||
| .to("alice", "bob") |
Member
There was a problem hiding this comment.
This sort of gratuitous reformatting makes it harder to review changes. Is this imposed by a limitation of some automated tool?
# Conflicts: # src/test/java/org/jenkinsci/plugins/docker/commons/credentials/DockerServerEndpointTest.java # src/test/java/org/jenkinsci/plugins/docker/commons/impl/HostOnlyRegistryKeyMaterialFactoryTest.java # src/test/java/org/jenkinsci/plugins/docker/commons/impl/RegistryKeyMaterialFactoryTest.java # src/test/java/org/jenkinsci/plugins/docker/commons/util/SampleDockerBuilder.java
Contributor
Author
|
@jenkinsci/docker-commons-plugin-developers Kindly requesting a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
There are two exceptions where tests use rules that have not yet been migrated to JUnit5:
DockerServerCredentialsBindingTestusingJenkinsSessionRule(migrated fromRestartableJenkinsRule)DockerServerCredentialsHandlerTestusingJenkinsSessionRule(migrated fromRestartableJenkinsRule)I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.