[JENKINS-52724/JENKINS-52737] Inherit properties from the local docker config.json#72
Merged
oleg-nenashev merged 2 commits intojenkinsci:masterfrom May 13, 2019
kvalev:proxy
Merged
[JENKINS-52724/JENKINS-52737] Inherit properties from the local docker config.json#72oleg-nenashev merged 2 commits intojenkinsci:masterfrom kvalev:proxy
oleg-nenashev merged 2 commits intojenkinsci:masterfrom
kvalev:proxy
Conversation
Contributor
Author
|
@jglick Can you please take a look at this PR. |
Member
|
Probably right? Did not look closely. |
Member
|
Amends #67 IIUC. |
Member
|
@dwnusbaum did you have a chance to review it? |
Member
|
@oleg-nenashev No, the main patch seems fine at a glance but I'd want to look through Docker docs to understand what exactly can be in the file to see if anything else should be blacklisted before approving. |
oleg-nenashev
approved these changes
May 13, 2019
Member
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
It looks OK from my PoV. There are some edge cases with file handling, but the logic is good enough
oleg-nenashev
changed the title
dwnusbaum
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new config folder, try to copy some of the properties of the existing config.json file.
Fixes JENKINS-52724 and JENKINS-52737.