fix: use correct syntax for environment variable

[viceice]

Environment variables need an other syntax for be usable on windows bat.
This PR fixes JENKINS-67578 and JENKINS-67589.
Commit b3a6996 has broken this plugin for windows users.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[viceice]

@car-roll @rsandell Not sure how to test this

[car-roll]

You can try to replicate some of the examples in the Jenkins issues in the corresponding test class. Just looking quickly, I can see some examples using withServer and withRegistry. Those methods are tested in https://github.com/jenkinsci/docker-workflow-plugin/blob/master/src/test/java/org/jenkinsci/plugins/docker/workflow/DockerDSLTest.java
That might be the place to start.

[viceice]

Tests timed out 😕

[TBBle]

Something has broken on the CI cluster in the last week, because steps before the code changes are taking 10's of minutes that previously took 10's of seconds.

Oh, since I last looked a new run happened and appears to have been back to the previous times. So the problem must have been temporary, or has been resolved.

[viceice]

A related fix:

• [JENKINS-67572] Allow docker digest in image names docker-commons-plugin#93

[viceice]

Will try to add some tests now

[viceice]

#245

Seems not possible yet, as there is no docker infra on the ci windows agents

[rsandell]

@viceice Thanks for the fix! If you can vouch that it works on your windows machine I think that would be good enough for me to merge :)

[viceice]

@viceice Thanks for the fix! If you can vouch that it works on your windows machine I think that would be good enough for me to merge :)

Will validate on our jenkins now

[viceice]

Verified, works for me with artifact from jenkins build of this PR. 🎉