Open
Conversation
Member
|
Thanks for looking into this! Personally, I do not see the use-case that would motivate making this configurable on a per-service level. Java do have a mechanism to trust certificates of services it integrates with - the truststore. You do not have to do anything on the implementation side, and admins can add splunk cert if needed in a conventional way. I do not feel strongly whether to additionally enable Splunk cert management in UI, but I strongly encourage it should default to java truststore if not specified. |
Author
|
yes, it default to JDK trustStore but allows user to add extra CA, just like curl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@olivergondza please help test this PR