Capability to detect whether a database already exists without creating it#46
Open
pbenschop wants to merge 1 commit intojensarps:masterfrom
Open
Capability to detect whether a database already exists without creating it#46pbenschop wants to merge 1 commit intojensarps:masterfrom
pbenschop wants to merge 1 commit intojensarps:masterfrom
Conversation
…ng it Add cancelIfNew and cancelMsg options to support checking whether a database exists without creating it.
Owner
|
Hi @pbenschop, thanks for all your PRs! Really awesome to see that you're contributing back the changes you made to IDBWrapper. Please give me some time to look through these, that's a lot of code to check out. Thanks again! |
Contributor
Author
|
Hi Jens, thank you for putting this IDBWrapper together in the first place; great piece of work that provide me with good insight how IndexedDB works. In case you decide to accept these changes (which we hope), feel free of course, to change things around if you think there are better ways to achieve the same thing. |
|
Hi guys, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jens, I am with GreatVines in Portland, USA. We used IDBWrapper to create a mock implementation of the Salesforce SmartStore (a database component in the Salesforce Mobile SDK). Since SmartStore allows you to check for the physical presence of a "soup" (represented as a store in IndexedDB) without creating it, we added the capability to the openDB method to abort the transaction if the intent is to only check whether a database exists (without actually creating it). See the added cancelIfNew and CancelMsg options. Maybe this feature could be added to IDBWrapper.
Peter