Deprecations: remove VERSION monkey patch
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** This removes the monkey patch to the `VERSION` string, and updates `Builder` to not need it. **Why** Ruby 3.4 gives a warning about frozen strings, so adding the `<=>` method to the `VERSION` string is verboten. Looking at `Builder`, it seems like the version could *never* be `<= "0.1.3"` going forward, so the condition no longer seems necessary. We could alternatively add some different version checking logic, but I thought I'd go the route of deleting code if it's not used. Happy to make adjustments if preferred.
|
Could we merge this to get rid of the warning? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This removes the monkey patch to the
VERSIONstring, and updatesBuilderto not need it.Why
Ruby 3.4 gives a warning about frozen strings, so adding the
<=>method to theVERSIONstring is verboten. Looking atBuilder, it seems like the version could never be<= "0.1.3"going forward, so the condition no longer seems necessary.We could alternatively add some different version checking logic, but I thought I'd go the route of deleting code if it's not used. Happy to make adjustments if preferred.