New button "temp Hide" - to temporary hide highlights on page, just r…#56
Open
dmytrovoytko wants to merge 1 commit intojeromepl:mainfrom
Open
New button "temp Hide" - to temporary hide highlights on page, just r…#56dmytrovoytko wants to merge 1 commit intojeromepl:mainfrom
dmytrovoytko wants to merge 1 commit intojeromepl:mainfrom
Conversation
…eload to see them again
jeromepl
reviewed
Jun 25, 2023
Owner
jeromepl
left a comment
jeromepl
left a comment
There was a problem hiding this comment.
Hi @dmytrovoytko, thanks for the interest in the extension.
Could you tell me a bit more about why you wanted/needed this feature? I'm trying to gauge if this is something that most users would want or if it would clutter the UI for most.
Otherwise, could you remove all the +++ and ^^^ comments from the code please? It's not something we want on the main branch and make review slighlty harder.
Thanks!
| @@ -1,4 +1,7 @@ | |||
| export { default as highlightText } from './highlightText.js'; | |||
| //+++ | |||
| export { default as hideHighlight } from './hideHighlight.js'; | |||
Owner
There was a problem hiding this comment.
I think this file is missing from the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated these changes