bugfix: always calling wake leads to an unnecessary busy loop#4
Open
SohumB wants to merge 1 commit intojerry73204:masterfrom
Open
bugfix: always calling wake leads to an unnecessary busy loop#4SohumB wants to merge 1 commit intojerry73204:masterfrom
SohumB wants to merge 1 commit intojerry73204:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure these calls to
wakeare spurious, as the underlying flume receiver will callwakecorrectly when we poll it. In my tokio application, I can observe that these calls lead to busyloops —tees constantly end up having theirpoll_nextmethod called uselessly.Tests pass under both runtimes.