Removes --asroot for pacman v4.2.0 compatibiliity

[logankoester]

Sets default pacman.build_user to nobody and removes --asroot option, which was removed from pacman in 4.2.0

[logankoester]

I have now fixed the build for this branch (foodcritic rule FC019).

[jesseadams]

Thanks for fixing the build. These changes look good. However, I'd prefer to keep the default behavior to use the root user while allowing you to override this with another user. Are you willing to make that happen please? I know using makepkg as root is a bad idea but this cookbook was inherited from the Chef folks and I'd like to keep it consistent with previous behavior. Otherwise, we are looking at a major version bump.

Thanks!

[logankoester]

Hey @jesseadams, I don't mind making that compromise if that's what you need to get this merged, but before I do, I'd just like to clarify that you're aware of:

1. makepkg will refuse to run as root under all circumstances since pacman v4.2.0. Thus, a root user default will be a broken default in all cases.
2. There is no burden of backwards-compatibility with earlier versions of pacman, due to the rolling-release nature of the Arch distribution.

If you understand this and still maintain your preference for some reason I haven't considered, I'll be happy to make the change - just let me know!

[logankoester]

@jesseadams Any thoughts on my previous comment?

[nogweii]

A friendly ping, can this be merged in?

[jesseadams]

I am going to look back into this.

[logankoester]

Thanks @jesseadams!