Revert-store #22
Open
Revert-store #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StoreCopy tool's output formatting doesn't behave reliably when there's a lot of compaction going on. A lot of the '.'s are skipped and the line-ending summaries are skipped when a node or relationship with the current node ID or rel ID doesn't exist (because that information is outputted after getting the node / relationship). This resolves that so that every line is approximately the same length and there's a line per every 500000 nodes/relationships. This change also ups the number of nodes per '.' and per line.
Clean up StoreCopy output formatting
similar to copyRelationships method, try-catch block is added to skip faulty node records, and continue with copying.
added try-catch block in copyNodes methods
* 22: StoreComparer: add missing transaction wrapping. better error handling
StoreComparer: add missing transaction wrapping
#15) This is needed because during shutdown batch inserter tries to flush it's caches and some entities in those caches might be corrupt for the source database. Problem initially seen for unused dynamic label records.
- allow for labels to be specified that cause their nodes to be deleted - allow for relationships to be skipped if their nodes have not been copied - allow for specification if node-ids should be compacted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating pull request for neo4j upgrade