Skip to content

Conversation

@andreihrybo
Copy link
Contributor

Implemented handling of revert_action in the context manager and added logging for the recover_notification message inside the context manager so that errors don’t need to be handled outside of it.
Updated/modified the logger methods so that it stores recover_notification separately for each context manager by pid. This will allow using a single logger for multiple context managers.
Wrote detailed tests for the context managers, simulating different points where errors can occur and how they are handled.
Updated the gcts branch update_filesystem method.

@andreihrybo andreihrybo force-pushed the refactore-context-managers branch 2 times, most recently from 2b5aa3c to 16ee722 Compare November 25, 2025 14:24
@andreihrybo andreihrybo force-pushed the refactore-context-managers branch from 16ee722 to e9e5c79 Compare November 25, 2025 14:26
@jfilak
Copy link
Owner

jfilak commented Nov 25, 2025

I did review and created a new brach in this repo.

I squashed your commits (leaving out the cosmetic change):

And then modified your changes to match my idea:

@jfilak
Copy link
Owner

jfilak commented Nov 27, 2025

Thank you! I pushed 7d27fb9 to the branch master.

@jfilak jfilak closed this Nov 27, 2025
@andreihrybo andreihrybo deleted the refactore-context-managers branch November 27, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants