Skip to content

Conversation

@andreihrybo
Copy link
Contributor

Main point printing recover messages only if it present

Andrei Hrybouski and others added 2 commits November 25, 2025 20:33
We plan to enhance the sugar operation clone with the options like
no-import or buffer-only. Those operation temporarily changes gCTS
configuration and for that activity we use context managers with
loggers. To avoid the need pass new Sugar Operation logger instance for
each sugar operation context manager we need to be able to pass only 1
instance of logger which would be able to handle updates from many
context managers.

There are two problems which we need to solve:
- the observer must be able to clear the recover after the configuration
  change is restored
- since the "print recover message" logic is getting more complicated we
  must enhance the context manager to trigger it on its own
@andreihrybo andreihrybo force-pushed the refactore-context-managers-v2 branch from fcea340 to b61aba7 Compare November 26, 2025 11:38
@andreihrybo andreihrybo force-pushed the refactore-context-managers-v2 branch from b61aba7 to 1ffac79 Compare November 26, 2025 13:26
@jfilak
Copy link
Owner

jfilak commented Nov 27, 2025

Thank you! I pushed 7d27fb9

@jfilak jfilak closed this Nov 27, 2025
@andreihrybo andreihrybo deleted the refactore-context-managers-v2 branch November 27, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants