Fix multi-target flattening in scan-repository #1003
+129
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalk007
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalk007
force-pushed
the
fix-multi-target-flattening
branch
from
e6cc8fc to
fa8cc30
Compare
When JFrog CLI auto-detects multiple working directories, ConvertToSimpleJson flattens all results together, losing the association between vulnerabilities and their specific working directories. This fix: 1. Uses IncludeTargets parameter to filter each target separately 2. Limits package handler file walks to current directory only - Prevents fixing vulnerabilities in auto-detected subdirectory targets - Each target processes its own descriptor files independently Depends on: IncludeTargets feature in jfrog-cli-security (currently in attiasas/convert_include_targets branch)
eyalk007
force-pushed
the
fix-multi-target-flattening
branch
from
fa8cc30 to
d0561b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JFrog CLI auto-detects multiple working directories,
ConvertToSimpleJsonflattens all results together, losing the association between vulnerabilities and their specific working directories. In cases of multi-module, this causes fixes to be attempted at root level and not the correct target.This fix:
ConvertTargetToSimpleJson