-
Notifications
You must be signed in to change notification settings - Fork 86
Optimize tests for v3 #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3_er
Are you sure you want to change the base?
Optimize tests for v3 #1007
Conversation
…lations Only Package Handlers tests need all package managers installed since they test the fix functionality. Other test suites (Unit, Scan Repository, Scan Pull Request) don't need npm, Python, pipenv, poetry, Mono, dotnet, NuGet, Pnpm, Java, or Conan installations. This will significantly speed up test execution for non-Package Handler test suites.
8fa64b5 to
8c06d3a
Compare
Added Go module cache (~/go/pkg/mod) to all integration test jobs: - github-integration - azure-integration (ubuntu, windows, macos) - gitlab-integration (ubuntu, windows, macos) - bitbucket-server-integration (macos) This matches the caching already used in the main tests and Pretest jobs. Subsequent test runs will restore cached Go modules (~5s) instead of re-downloading them (~30-60s).
| ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}- | ||
| ${{ runner.os }}-go- | ||
| # Package managers are only needed for Package Handlers tests (fix functionality) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about integration tests that run Scan-pr and Scan-repo commands and require to perform actual upgrades and dependencies resolutions?
eranturgeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflows changes in Frogbot only applied after merge, therefore the changes you've made cannot be validated in the tests execution of this PR (running agains the old yml files)
please validate all tests are passing in your fork

We dont need to install the package managers anymore
we only need them for the fix part meaning only for hte package manager suite