Skip to content

Conversation

@eyalk007
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

We dont need to install the package managers anymore
we only need them for the fix part meaning only for hte package manager suite

…lations

Only Package Handlers tests need all package managers installed since they test the fix functionality.
Other test suites (Unit, Scan Repository, Scan Pull Request) don't need npm, Python, pipenv, poetry, Mono, dotnet, NuGet, Pnpm, Java, or Conan installations.

This will significantly speed up test execution for non-Package Handler test suites.
@eyalk007 eyalk007 self-assigned this Dec 23, 2025
@eyalk007 eyalk007 added the ignore for release Automatically generated release notes label Dec 23, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 23, 2025
Added Go module cache (~/go/pkg/mod) to all integration test jobs:
- github-integration
- azure-integration (ubuntu, windows, macos)
- gitlab-integration (ubuntu, windows, macos)
- bitbucket-server-integration (macos)

This matches the caching already used in the main tests and Pretest jobs.
Subsequent test runs will restore cached Go modules (~5s) instead of
re-downloading them (~30-60s).
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 23, 2025
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Dec 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 23, 2025
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}-
${{ runner.os }}-go-
# Package managers are only needed for Package Handlers tests (fix functionality)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about integration tests that run Scan-pr and Scan-repo commands and require to perform actual upgrades and dependencies resolutions?

Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows changes in Frogbot only applied after merge, therefore the changes you've made cannot be validated in the tests execution of this PR (running agains the old yml files)
please validate all tests are passing in your fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants