Skip to content

Add prop-types to support React 16 RC#14

Merged
jgimbel merged 1 commit intojgimbel:masterfrom
codeheroics:react16-support
Nov 18, 2017
Merged

Add prop-types to support React 16 RC#14
jgimbel merged 1 commit intojgimbel:masterfrom
codeheroics:react16-support

Conversation

@codeheroics
Copy link
Contributor

Since React 16 removes React.PropTypes, react-leaflet-div-icon breaks.

This PR adds the prop-types package and allows react & react-dom 16 RC in peer-dependencies.

@codeheroics
Copy link
Contributor Author

Just as I open this I realize the most important bit (React.PropTypes) is already in #13 from a pull request 3 months old.

@jgimbel do you plan on merging this or #13, or is react-leaflet-div-icon not maintained anymore?

@jgimbel jgimbel merged commit a310b39 into jgimbel:master Nov 18, 2017
@codeheroics
Copy link
Contributor Author

Hi, thanks for the merge! Do you plan on tagging a new version & publishing it to npm soon?

@cinthia3301andrad
Copy link

Hello, will this merge work for typescript typing?

I'm using typescript and I get the following error:
Cannot find module 'react-leaflet-div-icon' or its corresponding type declarations.ts(2307)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants