Extend norbert netty server and client with SSL support #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message ExecutorComponent
Added the ability to set a timeout in the RequestRunner subclass of Message ExecutorComponent
Whitespace change and increment version
latency is spent by netty
Fixing selective retry bug
Fixing null/None issue in selective retry, now passes tests
Version bump
Added more granular logging per request to show how much of the request
Version bump
Finished request latency granularity logging
remove old version of scala from being built
The basic strategy here is to insert a downstream channel handler before the default channel handler. This new handler will inspect the request to see if it is going to a mirrored host. If it is, it copies the request with, modifies the target host, stores the request id, and then sends the new request to the io client. We also install an upstream handler. This handler gets responses beofre the default channel handler. The new handler checks to see if a response is for a mirrored request. If it is, it stops propagation of the response, hence ensuring that the dark responses can never reach the production client.
1) Made zookeeper drive the configuration of mirrored hosts. We can now disable dark canaries completely
by marking dark canary hosts unavailable in Zookeeper.
2) The zookeeper service name that the dark canary handler connects to is part of the NetworkClientConfiguration
and can be populated by existing means (through spring, etc.)
3) Made the DarkCanaryChannelHandlers no-ops if no Zookeeper serviceName is configured.
…ject. This way we have one handler, and hence one ZooKeeperClusterClient per PartitionedNetworkClient. The previous setup would not have worked if we had multiple PartionedNetworkClient objects in a single process: they would all have shared the same zookeeper client, and only one of them would have got the correct dark canary configurations.
…ed to change it and the changes were breaking some tests.
Adding the stats for the number of bytes sent and received from client.
Changing metrics to return KB instead of Bytes.
Fixing the rece condition in grabbing mirrored host info
Extract writeRequested call from catch statement
Fixing server thread pool JMX stats
[norbert] Extend norbert netty server and client with SSL support for cloud service.
Enabled publications to bintray
Scala 2.11.12 migration
Module name without minor version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend norbert netty server and client with SSL support for cloud service.