Fix sync issue with newly added groups in HISinOne #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when new groups were added in HISinOne after the first sync to the ECS server, they were created as courses in ILIAS but without participants, and participant lists were mixed up across courses. Thanks to Ilja's fix, the participant mixing issue was resolved. However, the issue with new groups being created without participants persisted. The root cause was that ILIAS fetched the first available messages from the ECS server, which did not contain the information for the newly added groups. This fix introduces an `ORDER BY econtent_id DESC` in the ECS message fetching process, ensuring that ILIAS retrieves the most recent messages with accurate participant data. This commit includes Ilja's fix Note: It is unclear whether this change might affect other ECS-related issues. 
jheim2
force-pushed
the
8/ECS/enhancement/ecs-parallel-groupe
branch
from
b7a6a0a to
cabed7b
Compare
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when new groups were added in HISinOne after the first sync to the ECS server, they were created as courses in ILIAS but without participants, and participant lists were mixed up across courses. Thanks to Ilja's fix, the participant mixing issue was resolved. However, the issue with new groups being created without participants persisted.
The root cause was that ILIAS fetched the first available messages from the ECS server, which did not contain the information for the newly added groups. This fix introduces an
ORDER BY econtent_id DESCin the ECS message fetching process, ensuring that ILIAS retrieves the most recent messages with accurate participant data.This commit includes Ilja's fix
Note: It is unclear whether this change might affect other ECS-related issues.