Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Conversation

@Spriz
Copy link
Collaborator

@Spriz Spriz commented Aug 28, 2019

As plugins can contain multiple prefixes, right now with these 2 urls:

Plugin: Api
Prefix: Users
Controller: Actions
Action: index
Plugin: Api
Prefix: Posts
Controller: Comments
Action: index

Would become:

/Users/Api/Actions/index and /Posts/Api/Comments/index

But I see having multiple plugins, with same prefixes in as a quit normal use case - so one could have 2 plugins with Api prefix in it, and now the grouping is what I would consider wrong.

Plugin: Forum
Prefix: Api
Controller: Posts
Action: index
Plugin: Admin
Prefix: Api
Controller: Posts
Action: index

Will be grouped as Api/Forum/Posts/index and /Api/Admin/Posts/index 🤔

I think the better ones would be Forum/Api/Posts/index and Admin/Api/Posts/index

EDIT: Note, this will change the transaction names in NewRelic - so I would consider this BC breaking

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants