This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Use the plugin as the most important grouping mechanism #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As plugins can contain multiple prefixes, right now with these 2 urls:
Would become:
/Users/Api/Actions/indexand/Posts/Api/Comments/indexBut I see having multiple plugins, with same prefixes in as a quit normal use case - so one could have 2 plugins with
Apiprefix in it, and now the grouping is what I would consider wrong.Will be grouped as
Api/Forum/Posts/indexand/Api/Admin/Posts/index🤔I think the better ones would be
Forum/Api/Posts/indexandAdmin/Api/Posts/indexEDIT: Note, this will change the transaction names in NewRelic - so I would consider this BC breaking