forked from leanprover-community/mathlib4
-
Notifications
You must be signed in to change notification settings - Fork 4
Add 09GY lemma to AlgebraicClosure.lean #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
su00000
wants to merge
13
commits into
master
Choose a base branch
from
add-09GY
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2a71c88
first tag
jjdishere a99968c
09GR + 09GS + 09GT
2b9d2b9
comment
42b281d
finish 10
3126ac3
delete *
2ad82c3
add 09GR
173693b
refine
2688ab4
Merge branch 'master' into stacks_project_tag
jjdishere ba8b0fd
CI for fork
jjdishere 41b44b8
Update AlgebraicClosure.lean
su00000 082bec0
remove checkworkflow
jjdishere 832442c
Merge branch 'leanprover-community:master' into master
jjdishere bb960f3
Merge branch 'master' into add-09GY
jjdishere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -346,7 +346,10 @@ attribute [local instance] AlgebraicClosureAux.field AlgebraicClosureAux.instAlg | |
| AlgebraicClosureAux.instIsAlgClosed | ||
|
|
||
| /-- The canonical algebraic closure of a field, the direct limit of adding roots to the field for | ||
| each polynomial over the field. -/ | ||
| each polynomial over the field. | ||
|
|
||
| [Stacks: Lemma 09GT](https://stacks.math.columbia.edu/tag/09GT) | ||
| -/ | ||
| def AlgebraicClosure : Type u := | ||
| MvPolynomial (AlgebraicClosureAux k) k ⧸ | ||
| RingHom.ker (MvPolynomial.aeval (R := k) id).toRingHom | ||
|
|
@@ -413,4 +416,25 @@ instance [CharZero k] : CharZero (AlgebraicClosure k) := | |
| instance {p : ℕ} [CharP k p] : CharP (AlgebraicClosure k) p := | ||
| charP_of_injective_algebraMap (RingHom.injective (algebraMap k (AlgebraicClosure k))) p | ||
|
|
||
| /-09GY Lemma: Two polynomials in $k[x]$ are relatively prime | ||
| precisely when they have no common roots in an algebraic closure $\overline{k}$ of $k$. | ||
| [Stacks: Lemma 09GY](https://stacks.math.columbia.edu/tag/09GY) -/ | ||
| lemma IsComrime_iff_no_common_root {k : Type*} [Field k] {p q : Polynomial k} : | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The name should change to |
||
| IsCoprime p q ↔ (¬ ∃ r : AlgebraicClosure k, IsRoot (map (algebraMap k (AlgebraicClosure k)) p) r ∧ | ||
| IsRoot (map (algebraMap k (AlgebraicClosure k)) q) r) := by | ||
| letI := Classical.typeDecidableEq (AlgebraicClosure k) | ||
| rw [← isCoprime_map (algebraMap k (AlgebraicClosure k)), | ||
| ← EuclideanDomain.gcd_isUnit_iff, isUnit_iff_degree_eq_zero, iff_not_comm] | ||
| constructor | ||
| · intro ⟨r, hr⟩ | ||
| by_contra h | ||
| rw [← isUnit_iff_degree_eq_zero, isUnit_iff] at h | ||
| rcases h with ⟨c, unc, polc⟩ | ||
| rw [← isRoot_gcd_iff_isRoot_left_right, ← polc, IsRoot.def, eval_C] at hr | ||
| rw [hr, isUnit_iff_ne_zero] at unc | ||
| exact unc rfl | ||
| · intro h | ||
| rcases IsAlgClosed.exists_root _ h with ⟨r, hr⟩ | ||
| exact ⟨r, isRoot_gcd_iff_isRoot_left_right.mp hr⟩ | ||
|
|
||
| end AlgebraicClosure | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/--instead of/-, as this will generate comments on the Mathlib documentation website.